-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit backports.entry_points_selectable for Python >=3.10 #2238
Conversation
Thank you! |
docs/changelog/2238.misc.rst
Outdated
@@ -0,0 +1 @@ | |||
Omit backports.entry_points_selectable for Python >=3.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this as a feature please and not misc; misc basically reserved for project maintenance files only, not that affects code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can we drop backports.entry_points_selectable
entirely here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we can if we require importlib-metadata>=3.6;python_version<"3.10"
and do:
if sys.version_info >= (3, 10):
from importlib.metadata import entry_points
else:
from importlib_metadata import entry_points
-- not sure if that is much better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively can we use the old API on old pythons and the new API on new Pythons? Rather than try to use the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this? #2241
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added as feature. The other PR would fit my needs as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer 2241, so will be closing this.
If I understood backports.entry_points_selectable documentation correctly, this is equivalent.
Change is proposed to update above 20.4.7 on Void Linux, which is on python 3.10 already, without fuss of adding the backport module to repository.
tox -e fix_lint
)docs/changelog
folder