Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump setuptools and fix Windows subprocess with cwd broken #1982

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Bump setuptools and fix Windows subprocess with cwd broken #1982

merged 2 commits into from
Oct 15, 2020

Conversation

gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented Oct 15, 2020

Signed-off-by: Bernát Gábor [email protected]

Resolves #1983

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1982 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1982   +/-   ##
=======================================
  Coverage   94.13%   94.14%           
=======================================
  Files          86       86           
  Lines        4266     4269    +3     
=======================================
+ Hits         4016     4019    +3     
  Misses        250      250           
Flag Coverage Δ
#tests 94.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/seed/wheels/embed/__init__.py 100.00% <ø> (ø)
src/virtualenv/util/subprocess/_win_subprocess.py 95.31% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567d64b...58b7edc. Read the comment docs.

Signed-off-by: Bernát Gábor <[email protected]>
@gaborbernat gaborbernat changed the title Bump setuptools Bump setuptools and fix Windows subprocess with cwd broken Oct 15, 2020
@gaborbernat gaborbernat merged commit 8f3d157 into pypa:main Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows subprocess calls with cwd are broken post virtualenv import
1 participant