-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade embeded setuptools #1855
Conversation
Signed-off-by: Bernat Gabor <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
- Coverage 88.84% 85.02% -3.83%
==========================================
Files 82 82
Lines 3946 3773 -173
==========================================
- Hits 3506 3208 -298
- Misses 440 565 +125
Continue to review full report at Codecov.
|
xonsh/xonsh#3618 Signed-off-by: Bernat Gabor <[email protected]>
@@ -61,7 +61,7 @@ virtualenv.activate = | |||
batch = virtualenv.activation.batch:BatchActivator | |||
fish = virtualenv.activation.fish:FishActivator | |||
powershell = virtualenv.activation.powershell:PowerShellActivator | |||
python = virtualenv.activation.python:PythonActivator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting an error that might be related to this merge. Is the change expected?
AttributeError: module 'virtualenv.activation.python' has no attribute 'PestythonActivator'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just broke all of my production build pipelines as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to be honest, have no idea how this change made it in. Late Friday releases are always dangerous but wanted to get out a fix release to address peoples issues due to #1846 🤦 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It happens. Thanks for the quick fix! @gaborbernat
Same issue here:
It's affecting my Bitbucket Pipelines :/ |
Haha. It seems we're missing tests here. |
No description provided.