Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upper bound on importlib-resources (2.0 works) #1851

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Remove upper bound on importlib-resources (2.0 works) #1851

merged 1 commit into from
Jun 9, 2020

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jun 9, 2020

this fixes a diamond incompatibility with pre-commit when installed on python<3.8

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #1851 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1851      +/-   ##
==========================================
+ Coverage   88.72%   88.77%   +0.05%     
==========================================
  Files          82       82              
  Lines        3946     3946              
==========================================
+ Hits         3501     3503       +2     
+ Misses        445      443       -2     
Flag Coverage Δ
#tests 88.77% <ø> (+0.05%) ⬆️
Impacted Files Coverage Δ
...ualenv/create/via_global_ref/builtin/pypy/pypy2.py 98.70% <0.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5addca7...0d17a22. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants