Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEGACY: Only get setuptools < 44 on Python 3.4 #1677

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Feb 27, 2020

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@hroncok hroncok changed the title Only get setuptools < 44 on Python 3.4 LEGACY: Only get setuptools < 44 on Python 3.4 Feb 27, 2020
This allows to have multiple setuptools versions (for 3.4 and newer).
@hroncok hroncok force-pushed the legacy-setuptools44 branch from fcf73b3 to bd66afe Compare February 27, 2020 15:12
@hroncok hroncok marked this pull request as ready for review February 27, 2020 23:14
@hroncok
Copy link
Contributor Author

hroncok commented Feb 27, 2020

This works and enables us to update setuptools in Fedora.

@gaborbernat gaborbernat merged commit 4c9899f into pypa:legacy Feb 27, 2020
@hroncok hroncok deleted the legacy-setuptools44 branch February 27, 2020 23:24
@hroncok
Copy link
Contributor Author

hroncok commented Feb 27, 2020

Thanks. No need for a release from our pov.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants