handle application data folder is read only #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need a better solution for this in a sense that we should clean-up the temporay folder when this is not the app-data. |
|
@yakkle thanks for starting the work on this, I'll take up continuing this PR, this requires major changes to make it right. |
gaborbernat
force-pushed
the
feature/fix-not-writable-user-data-dir
branch
from
dc55b29 to
f151f37
Compare
- when using docker, if `user_data_dir()` isn't writable directory, `default_data_dir()` use `system temp directory` + `virtualenv`. for example, tempdir is `/tmp`, it use `/tmp/virtualenv`
gaborbernat
force-pushed
the
feature/fix-not-writable-user-data-dir
branch
3 times, most recently
from
107c479 to
b2994d4
Compare
gaborbernat
changed the title
gaborbernat
force-pushed
the
feature/fix-not-writable-user-data-dir
branch
2 times, most recently
from
0c0f3ad to
68f030e
Compare
Signed-off-by: Bernat Gabor <[email protected]>
gaborbernat
force-pushed
the
feature/fix-not-writable-user-data-dir
branch
from
68f030e to
e8eee79
Compare
Signed-off-by: Bernat Gabor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using docker, if
user_data_dir()isn't writable directory,default_data_dir()usesystem temp directory+virtualenv.for example, tempdir is
/tmp, it use/tmp/virtualenvThanks for contributing a pull request, see checklist all is good!
docs/changelogfolder