Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover python interpreter in a case insensitive manner #1629

Merged
merged 1 commit into from
Feb 15, 2020
Merged

Discover python interpreter in a case insensitive manner #1629

merged 1 commit into from
Feb 15, 2020

Conversation

PrajwalM2212
Copy link
Contributor

Closes #1624

Thanks for contributing a pull request, see checklist all is good!

  • wrote descriptive pull request text
  • added/updated test(s)
  • updated/extended the documentation
  • added news fragment in docs/changelog folder

gaborbernat
gaborbernat requested changes Feb 14, 2020
View reviewed changes
docs/changelog/1624.bugfix.rst Outdated Show resolved Hide resolved
@PrajwalM2212 PrajwalM2212 force-pushed the py_impl branch 2 times, most recently from 9eabd42 to 594accf Compare February 14, 2020 17:08
ssbarnea
ssbarnea suggested changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that we should add logic to count for case-sensitivity. This is OS layer responsability. If the user gives a specific case, we should use that, without extra conversion.

gaborbernat
gaborbernat requested changes Feb 15, 2020
View reviewed changes
src/virtualenv/discovery/py_info.py Show resolved Hide resolved
tests/unit/discovery/py_info/test_py_info.py Outdated Show resolved Hide resolved
@PrajwalM2212 PrajwalM2212 changed the title py_info.py: Discover python interpreter in a case insensitive manner Discover python interpreter in a case insensitive manner Feb 15, 2020
@gaborbernat gaborbernat merged commit 39b2ed7 into pypa:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

@gaborbernat gaborbernat Awaiting requested review from gaborbernat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discover python in a case insensitive way
3 participants
@PrajwalM2212 @ssbarnea @gaborbernat