Fix failing to acquire lock in case of parallel runs #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bernat Gabor <[email protected]>
asottile
reviewed
Jan 29, 2020
| try: | ||
| os.makedirs(str(self.path)) | ||
| except OSError: | ||
| pass |
There was a problem hiding this comment.
this should only catch the exception if it's EEXIST and it's a directory I believe -- other OSErrors should raise here (in py3+ os.makedirs(..., exist_ok=True))
There was a problem hiding this comment.
not too worried about this, as if this fails for any other reason than EEXIST the next line will also fail, and done it like this to handle both platforms 🤔 I know about exists_ok=True... but that does not work on python 2...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1516