Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some notes in changelog or docs about site after v20.0.0b1 #2378

Closed
YouJiacheng opened this issue Jul 18, 2022 · 1 comment · Fixed by #2379
Closed

Add some notes in changelog or docs about site after v20.0.0b1 #2378

YouJiacheng opened this issue Jul 18, 2022 · 1 comment · Fixed by #2379

Comments

@YouJiacheng
Copy link
Contributor

There are lots of issues about site.py in legacy implementation.
But thing seems completely different in the second iteration of implementation, according to the source code, #2105, #2106 and #1421 (comment).
This could be confusing, e.g. https://stackoverflow.com/a/46071447 said "With virtualenvs getsitepackages is not available".
When I searched about this, there isn't any thing tell me the thing is differenet now, I only got numerous issues that said virtualenvs doesn't support site module well.
Related issues:
#228
#355
#434
#571
#587
#737
#1250 (link in this issue should be updated to https://github.com/pypa/virtualenv/blob/legacy/virtualenv_embedded/site.py)
They all said "there isn't site.getsitepackages".

@gaborbernat
Copy link
Contributor

Please open a PR for it 👍

YouJiacheng added a commit to YouJiacheng/virtualenv that referenced this issue Jul 18, 2022
gaborbernat pushed a commit to YouJiacheng/virtualenv that referenced this issue Jul 23, 2022
gaborbernat pushed a commit to YouJiacheng/virtualenv that referenced this issue Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants