Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_check on Windows #936

Closed
wants to merge 1 commit into from

Conversation

bhrutledge
Copy link
Contributor

@bhrutledge bhrutledge commented Oct 22, 2022

Some of the tests are failing consistently; verbose pytest logging shows errors like:

>       assert capsys.readouterr().out == f"Checking {sdist}: " + (
            "FAILED due to warnings\n" if strict else "PASSED with warnings\n"
        )
E       AssertionError: assert ('Checking '\n 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-unknown\\pytest-\x1b[1m0\x1b[0m\\test_warns_missing_description0\\dist\\test-package-\x1b[1m0.0\x1b[0m.\x1b[1m1.\x1b[0mtar.gz: '\n 'PASSED with warnings\n') == ('Checking '\n 'C:\\Users\\runneradmin\\AppData\\Local\\Temp\\pytest-of-unknown\\pytest-0\\test_warns_missing_description0\\dist\\test-package-0.0.1.tar.gz: '\n 'PASSED with warnings\n')
E         - Checking C:\Users\runneradmin\AppData\Local\Temp\pytest-of-unknown\pytest-0\test_warns_missing_description0\dist\test-package-0.0.1.tar.gz: PASSED with warnings
E         + Checking C:\Users\runneradmin\AppData\Local\Temp\pytest-of-unknown\pytest-0\test_warns_missing_description0\dist\test-package-0.0.1.tar.gz: PASSED with warnings
E         ?                                                                           ++++ ++++                                                   ++++   ++++ ++++  ++++

I can't make sense of that, and I don't have access to a Windows machine. I might be able to set up a cloud desktop, but if someone has a Windows machine, and is able to run the tests locally to reproduce this, I'd appreciate it.

@sigmavirus24
Copy link
Member

There seem to be extra bytes (control characters maybe?) in the captured output that aren't in the expected output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants