Tweak upload --verbose suggestion

[bhrutledge]

Building on #807, for #805. This seems a little clearer, and is no longer tied to the response text (because --verbose will also print useful debugging messages about credentials, etc.).

Uploading distributions to https://test.pypi.org/legacy/
Enter your username: 
Enter your password: 
Uploading twine-3.4.2.dev12+g6694f57.d20210619-py3-none-any.whl
100%|██████████| 41.7k/41.7k [00:00<00:00, 140kB/s] 
Error during upload. Retry with the --verbose option for more details.
HTTPError: 403 Forbidden from https://test.pypi.org/legacy/
Invalid or non-existent authentication information. See https://test.pypi.org/help/#invalid-auth for more information.

[sigmavirus24]

Non-blocking suggestion in-line

[sigmavirus24]

One thought I just had:

We have access to the CLI args, right? Could we print out the command with --verbose injected so they can copy paste it?

[bhrutledge]

Neat idea. I'll take a look.

[sigmavirus24]

I was thinking something as simple as:

>>> import itertools
>>> argv = ["twine", "upload", "--skip-progress-bar", "dist/*"]
>>> ' '.join(itertools.chain(argv[:2], ["--verbose"], argv[2:]))
'twine upload --verbose --skip-progress-bar dist/*'

[bhrutledge]

Looks like it's not that simple. Running twine upload -r testpypi dist/* with pdb gives me:

(Pdb) sys.argv
['/Users/bhrutledge/Dev/twine/venv/bin/twine', 'upload', '-r', 'testpypi', 'dist/twine-3.4.2.dev12+g6694f57.d20210619-py3-none-any.whl', 'dist/twine-3.4.2.dev12+g6694f57.d20210619.tar.gz']

I think showing that to users will be confusing, so I'm going to merge this as-is.

[sigmavirus24]

True, we will only see dist/* if run from tox or Windows. I don't think users will generally be confused about globs being expanded by their shell as that's how it works

[bhrutledge]

I'm not sure all/most new users understand shell globbing, and dist/* could potentially expand to lots of files. That, combined with the absolute path of twine, makes for a long string to copy and paste, and also obscures the addition of --verbose.