Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use external importlib_metadata package when python < 3.8 #751

Closed
wants to merge 1 commit into from
Closed

Only use external importlib_metadata package when python < 3.8 #751

wants to merge 1 commit into from

Conversation

PureTryOut
Copy link

importlib_metadata has been integrated into the Python standard library
in 3.8 and is thus unnecessary for any newer versions.
Let's only use the external importlib_metadata package when actually
running on a Python version that doesn't include it already

This is mostly useful for distributions where there is no need to
package importlib_metadata anymore, and it's future proofing for when
the external package stops being developed anymore

importlib_metadata has been integrated into the Python standard library
in 3.8 and is thus unnecessary for any newer versions.
Let's only use the external importlib_metadata package when actually
running on a Python version that doesn't include it already

This is mostly useful for distributions where there is no need to
package importlib_metadata anymore, and it's future proofing for when
the external package stops being developed anymore
@bhrutledge
Copy link
Contributor

@PureTryOut Thanks for the suggestion, but we're relying on new behavior in importlib_metadata, which will eventually be merged into Python's importlib.metadata. See #732 for details, including a discussion with a Fedora maintainer about the implications: #732 (comment).

@bhrutledge bhrutledge closed this Apr 13, 2021
@PureTryOut
Copy link
Author

Ouch, that I did not realize. The explanation by @jaraco there is sane and reasonable, I'll go ahead and just repackage importlib_metadata on Alpine Linux (for which I mainly made this MR) then.

Closing this and jaraco/keyring#507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants