Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround mypy issues with importlib.metadata #551

Merged
merged 5 commits into from
Dec 3, 2019
Merged

Workaround mypy issues with importlib.metadata #551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
502113a
Always use importlib_metadata to avoid mypy errors
bhrutledge Nov 29, 2019
50a389d
Revert "Always use importlib_metadata to avoid mypy errors"
bhrutledge Nov 30, 2019
61fdbe0
Rework imports and ignore known mypy issues
bhrutledge Nov 30, 2019
66e4166
Unpin mypy
bhrutledge Nov 30, 2019
4235837
Use version check instead of try/except
bhrutledge Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ commands =

[testenv:lint-mypy]
deps =
# pin to workaround #550
mypy<0.750
mypy
lxml
commands =
# TODO: Consider checking the tests after the source is fully typed
Expand Down
6 changes: 4 additions & 2 deletions twine/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@

__copyright__ = "Copyright 2019 Donald Stufft and individual contributors"

try:
import sys

if sys.version_info[:2] >= (3, 8):
import importlib.metadata as importlib_metadata
except ImportError:
else:
import importlib_metadata


Expand Down