Fix upload exit code #405
Merged
Fix upload exit code #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertion on the exception message was never being run
In the event that the upload is successful, the return should be something falsey (such as the implicit None) as this value will eventually be used to determine the exit code.
This was added accidentally in pypa#395 and was missed on review.
Codecov Report
@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 76.09% 77.99% +1.89%
==========================================
Files 14 14
Lines 728 727 -1
Branches 104 104
==========================================
+ Hits 554 567 +13
+ Misses 146 128 -18
- Partials 28 32 +4
Continue to review full report at Codecov.
|
theacodes
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403, this was accidentally added in #395.
Also adds/fixes some tests for the upload command.