Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve repository password from the keyring, allowing it to be store… #208

Merged
merged 7 commits into from
Aug 31, 2016
Merged

Resolve repository password from the keyring, allowing it to be store… #208

merged 7 commits into from
Aug 31, 2016

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Aug 29, 2016

…d securely and following conventions use by setuptools.upload.

…d securely and following conventions use by setuptools.upload.
@sigmavirus24
Copy link
Member

Hi @jaraco

Could you include some tests here for the behaviour of the functions you've added/modified? Also, can you update our setup.{py,cfg} to add an optional dependency on Keyring based on an extra?

@jaraco
Copy link
Member Author

jaraco commented Aug 29, 2016

Okay. Should be good to go now.

@sigmavirus24 sigmavirus24 merged commit a379bee into pypa:master Aug 31, 2016
@sigmavirus24
Copy link
Member

Thanks @jaraco!

@glyph
Copy link

glyph commented Oct 5, 2016

This is an awesome feature! I'm wondering though; how is one supposed to authenticate to Twine, to store the credential in the keyring in the first place? I'd rather put it there than in ~/.pypirc.

@jaraco
Copy link
Member Author

jaraco commented Oct 5, 2016

With keyring installed, keyring set <URL> <username> where URL is the PyPI upload URL and username is the username in pypirc. That will prompt for the password and save it to the keyring.

@glyph
Copy link

glyph commented Oct 5, 2016

@jaraco It would be nice if there were a twine login command that would do this - it's not obvious how to derive the upload URL in advance. (The default changed recently, and given that 'legacy' is in the URL now, I assume it will change again soon)

@glyph
Copy link

glyph commented Oct 5, 2016

@jaraco Does that seem like it would be within twine's roadmap?

@sigmavirus24
Copy link
Member

@glyph @jaraco doesn't determine the roadmap for Twine. :)

What about just twine configure that would allow things to work a bit like Rackspace's rack CLI? That's a behaviour I can get behind

@glyph
Copy link

glyph commented Oct 5, 2016

@sigmavirus24 While a configure verb would be nifty, I'd actually want a separate UI for persisting any secret materials; putting my password into ~/.pypirc manually is bad, but writing out a config file which contains a secret that I can't necessarily find or destroy is worse. If it were a guided UI that specifically called this out in its prompts then that would work for me.

@sigmavirus24
Copy link
Member

Right, I'm imagining something that's guided. We should open a new issue to track this. Would you mind doing that?

@glyph
Copy link

glyph commented Oct 5, 2016

@sigmavirus24 Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants