Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Someday: Use importlib.metadata from the standard library #773

Closed
bhrutledge opened this issue Jun 29, 2021 · 1 comment · Fixed by #1024
Closed

Someday: Use importlib.metadata from the standard library #773

bhrutledge opened this issue Jun 29, 2021 · 1 comment · Fixed by #1024

Comments

@bhrutledge
Copy link
Contributor

bhrutledge commented Jun 29, 2021 •
edited
Loading

Follow-up to #772 (review) and #732 (comment).

It'd be nice to remove the dependency on importlib_metadata in Python 3.10+, but Twine will still need it for as long as it supports older versions of Python. So, I think it's worth weighing the complexity of conditional imports vs. an additional dependency.

I think this should at least wait until 3.10 is officially released and is added to Twine's testing matrix. If we do decide to use importlib.metadata, then I think the version check should be done in one place, as suggested in #772 (comment).
@bhrutledge bhrutledge mentioned this issue Jun 29, 2021
Closed
@jakkdl
Copy link

jakkdl commented Apr 18, 2023

3.10 is now officially released, so this could be revisited. I'm open for writing a PR if you want.

eli-schwartz added a commit to eli-schwartz/twine that referenced this issue Oct 26, 2023
@eli-schwartz
Use the stdlib importlib.metadata when available
bbd46bd 
The use of importlib_metadata relies on features that were introduced in
python 3.10. Aside for that, it should be fine to use the stdlib
directly.

Fixes pypa#773
@eli-schwartz eli-schwartz mentioned this issue Oct 26, 2023
Merged
@jaraco jaraco closed this as completed in 5bf3f38 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use the stdlib importlib.metadata when available eli-schwartz/twine
2 participants
@bhrutledge @jakkdl