Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditionally require keyring #524

Closed
jaraco opened this issue Nov 10, 2019 · 1 comment · Fixed by #525
Closed

Unconditionally require keyring #524

jaraco opened this issue Nov 10, 2019 · 1 comment · Fixed by #525

Comments

@jaraco
Copy link
Member

jaraco commented Nov 10, 2019

In #519, it's become apparent that the optional importing of keyring adds a substantial burden to the project's maintenance, especially after adding type hints. Previously, the main way to opt out of keyring support in twine has been to avoid installing keyring, but as subsequent work showed (#338), that interface was insufficient.

The intention of keyring is to be installed and only to have any non-degenerate behavior when the environment indicates such behavior is relevant (i.e. a meaningful password system is present).

In keyring 15.1, released over a year ago, an additional feature, the --disable keyword was added for a user to easily disable keyring functionality.

I'd like to consider for twine to unconditionally depend on keyring and rely on --disable for users that require to disable this functionality.

@sigmavirus24
Copy link
Member

So long as the option isn't so vague as to be literally --disable for twine, I'm +1 on providing a way to disable Keyring without the hack of not installing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants