Display error when uploading signed file with no distribution (#932)

* Display error when uploading signed file with no distribution

Related to #931.

If a user only uploads a signed .asc file without any distribution
files, this now throws an error to make it more clear why Twine
doesn't do anything.

* Simplify logic

* Clarify error message

Co-authored-by: Jacob Woliver <[email protected]>

AUTHORS

@@ -32,3 +32,4 @@ Yesha Maggi <[email protected]>
 Cyril de Catheu <[email protected]> (https://catheu.tech/)
 Thomas Miedema <[email protected]>
 Hugo van Kemenade (https://github.com/hugovk)
+Jacob Woliver <[email protected]> (jmw.sh)

changelog/931.misc.rst

@@ -0,0 +1 @@
+Throws an error when uploading signed files without any distribution files.

tests/test_upload.py

@@ -178,6 +178,18 @@ def test_success_with_pre_signed_distribution(upload_settings, stub_repository):
     )
 
 
+def test_exception_with_only_pre_signed_file(upload_settings, stub_repository):
+    """Raise an exception when only a signed file is uploaded."""
+    # Upload only pre-signed file
+    with pytest.raises(exceptions.InvalidDistribution) as err:
+        upload.upload(upload_settings, [helpers.WHEEL_FIXTURE + ".asc"])
+
+    assert (
+        "Cannot upload signed files by themselves, must upload with a "
+        "corresponding distribution file." in err.value.args[0]
+    )
+
+
 def test_success_when_gpg_is_run(upload_settings, stub_repository, monkeypatch):
     """Add GPG signature generated by gpg command to uploaded package."""
     # Indicate that upload() should run_gpg() to generate the signature, which

twine/commands/upload.py

@@ -127,6 +127,12 @@ def upload(upload_settings: settings.Settings, dists: List[str]) -> None:
     repository = upload_settings.create_repository()
     uploaded_packages = []
 
+    if signatures and not packages_to_upload:
+        raise exceptions.InvalidDistribution(
+            "Cannot upload signed files by themselves, must upload with a "
+            "corresponding distribution file."
+        )
+
     for package in packages_to_upload:
         skip_message = (
             f"Skipping {package.basefilename} because it appears to already exist"