Support --skip-existing with GCP Artifact Registry

GCP includes the same "already exist" note as PyPI in a 400 response, but in `text` rather than `reason`. Fixes #816.
pypa · Nov 1, 2021 · 34cfed4 · 34cfed4
1 parent 658037f
commit 34cfed4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog/816.feature.rst b/changelog/816.feature.rst
@@ -0,0 +1 @@
+Allow the ``--skip-existing`` option to work with GCP Artifact Registry.
diff --git a/twine/commands/upload.py b/twine/commands/upload.py
@@ -58,8 +58,8 @@ def skip_upload(
     return (
         # pypiserver (https://pypi.org/project/pypiserver)
         status == 409
-        # PyPI / TestPyPI
-        or (status == 400 and "already exist" in reason)
+        # PyPI / TestPyPI / GCP Artifact Registry
+        or (status == 400 and any("already exist" in x for x in [reason, text]))
         # Nexus Repository OSS (https://www.sonatype.com/nexus-repository-oss)
         or (status == 400 and any("updating asset" in x for x in [reason, text]))
         # Artifactory (https://jfrog.com/artifactory/)