-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min Python version for GHA (and fix spurious CI error) #4716
Conversation
Since e47994c we are having problems with 3.8. This PR updates the versions to support the oldest and newest supported stable Python versions.
It turns up we have more errors happening in the CI, see jaraco/skeleton#152. |
@abravalheri Can you also bump Given the usual mentality with coherent-oss / skeleton projects, I think those can even be completely removed and it would be up to the user to tell their editor which Python version to test with at different moments (and handle their venv appropriatly). Rather than applying a minimum across the entire project, hoping it'd catch more issues during development. |
Regarding https://github.com/pypa/setuptools/actions/runs/11596788203/job/32288690596?pr=4716#step:9:133, I am tempted to let it > assert installed == {'aproj.egg-link'}
E AssertionError: assert set() == {'aproj.egg-link'}
E
E Extra items in the right set:
E 'aproj.egg-link'
E Use -v to get more diff
/Users/runner/work/setuptools/setuptools/setuptools/tests/test_easy_install.py:1467: AssertionError (This approach was implemented in b9dd033) |
@Avasam, I bumped the versions in the files you suggested. We can decide later to remove them. For now I just want to make the CI pass, so that we can keep the PRs going, later we can refine it. There should probably be a separated PR to remove stuff like |
pyright
GHA
Certainly. I just figured bumping the value in config sounded appropriate for this PR. |
Since e47994c we are having problems with 3.8.
This PR updates the versions to support the oldest and newest supported stable Python versions.
Summary of changes
Closes #4717
Pull Request Checklist
newsfragments/
.(See documentation for details)
/cc @Avasam for
pyright
GHA.