Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min Python version for GHA (and fix spurious CI error) #4716

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Oct 30, 2024

Since e47994c we are having problems with 3.8.

This PR updates the versions to support the oldest and newest supported stable Python versions.

Summary of changes

Closes #4717

Pull Request Checklist

/cc @Avasam for pyright GHA.

Since e47994c we are having problems with 3.8.

This PR updates the versions to support the oldest and newest supported stable Python versions.
@abravalheri abravalheri marked this pull request as draft October 30, 2024 15:34
@abravalheri
Copy link
Contributor Author

abravalheri commented Oct 30, 2024

It turns up we have more errors happening in the CI, see jaraco/skeleton#152.

@Avasam
Copy link
Contributor

Avasam commented Oct 30, 2024

@abravalheri Can you also bump pythonVersion in pyrightconfig.json and python_version in mypy.ini even if it's currently commented out ?

Given the usual mentality with coherent-oss / skeleton projects, I think those can even be completely removed and it would be up to the user to tell their editor which Python version to test with at different moments (and handle their venv appropriatly).
For example using VSCode:
image
(or in the linter plugin settings, which can be done per-workspace, and Jason made it clear we're not in the business of pre-configuring workspaces for specific editors)

Rather than applying a minimum across the entire project, hoping it'd catch more issues during development.

@abravalheri
Copy link
Contributor Author

abravalheri commented Oct 30, 2024

Regarding https://github.com/pypa/setuptools/actions/runs/11596788203/job/32288690596?pr=4716#step:9:133, I am tempted to let it xfail on macOS given that it regards a deprecated code path.

>       assert installed == {'aproj.egg-link'}
E       AssertionError: assert set() == {'aproj.egg-link'}
E         
E         Extra items in the right set:
E         'aproj.egg-link'
E         Use -v to get more diff

/Users/runner/work/setuptools/setuptools/setuptools/tests/test_easy_install.py:1467: AssertionError

(This approach was implemented in b9dd033)

@abravalheri
Copy link
Contributor Author

abravalheri commented Oct 30, 2024

@Avasam, I bumped the versions in the files you suggested. We can decide later to remove them.

For now I just want to make the CI pass, so that we can keep the PRs going, later we can refine it.

There should probably be a separated PR to remove stuff like if sys.version_info <= (3, 8).

@abravalheri abravalheri marked this pull request as ready for review October 30, 2024 16:06
@abravalheri abravalheri changed the title Bump Python version for pyright GHA Bump min Python version for GHA (and fix spurious CI error) Oct 30, 2024
@Avasam
Copy link
Contributor

Avasam commented Oct 30, 2024

There should probably be a separated PR to remove stuff like if sys.version_info <= (3, 8).

Certainly. I just figured bumping the value in config sounded appropriate for this PR.

@abravalheri abravalheri merged commit 3e3d16d into main Oct 30, 2024
44 checks passed
@abravalheri abravalheri deleted the bump-pyright branch October 30, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Python version misalignment in CI since last merge with skeleton
2 participants