Statically alias distutils-stubs to setuptools._distutils #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2024
Avasam
commented
Oct 25, 2024
setuptools/__init__.py
Outdated
| @@ -228,7 +223,7 @@ def reinitialize_command( | |||
| ) -> _Command: | |||
| cmd = _Command.reinitialize_command(self, command, reinit_subcommands) | |||
| vars(cmd).update(kw) | |||
| return cmd | |||
| return cmd # pyright: ignore[reportReturnType] # pypa/distutils#307 | |||
There was a problem hiding this comment.
Ref.: pypa/distutils#307
Avasam
force-pushed
the
statically-alias-distutils-stubs-to-setuptools._distutils
branch
5 times, most recently
from
1733d12
to
f950ecc
Compare
Avasam
force-pushed
the
statically-alias-distutils-stubs-to-setuptools._distutils
branch
3 times, most recently
from
47321db
to
7085815
Compare
Avasam
force-pushed
the
statically-alias-distutils-stubs-to-setuptools._distutils
branch
from
7085815
to
e66c7ae
Compare
|
I've added a comment at the top of geenrated files to make it clear that they are generated and how to regenerate them. |
Avasam
commented
Nov 25, 2024
Comment on lines
+183
to
+184
| ] + install.new_commands # type: ignore[operator] | ||
| # TODO: Type sub_commands/new_commands to avoid variance issues in pypa/distutils (like python/typeshed#11951) |
Avasam
commented
Nov 25, 2024
Comment on lines
-53
to
+58
| negative_opt: ClassVar[dict[str, str]] = {} | ||
| # TODO: Mark class-level mutables as ClassVars in pypa/distutils (like python/typeshed#12403) | ||
| negative_opt: ClassVar[dict[str, str]] = {} # type: ignore[misc] | ||
|
|
||
| README_EXTENSIONS = ['', '.rst', '.txt', '.md'] | ||
| READMES = tuple('README{0}'.format(ext) for ext in README_EXTENSIONS) | ||
| # TODO: Mark some class-level tuples as as not fixed-length pypa/distutils (like python/typeshed#12403) | ||
| READMES = tuple('README{0}'.format(ext) for ext in README_EXTENSIONS) # type: ignore[assignment] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #4689
This is an alternative to #4691. This makes type-checkers and editors see
distutilsas basically an alias tosetuptools.Advantage:
Disadvantage:
Pull Request Checklist
newsfragments/. (no need until this is shipped with setuptools)(See documentation for details)