Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge overloaded method definitions from typeshed #4506

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Merge overloaded method definitions from typeshed #4506

merged 2 commits into from
Aug 8, 2024

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Jul 22, 2024 •
edited
Loading

Summary of changes

Works towards #2345

Bring over all setuptools method that are @overloaded from typeshed

Pull Request Checklist

  • Changes have tests (existing static and unit tests should pass)
  • News fragment added in newsfragments/. (no user facing changes)
    (See documentation for details)

@Avasam Avasam mentioned this pull request Jul 22, 2024
Merged
2 tasks
jaraco
jaraco approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abravalheri abravalheri merged commit 314d656 into pypa:main Aug 8, 2024
21 checks passed
@abravalheri
Copy link
Contributor

Thank you!

@Avasam Avasam deleted the setuptools-typeshed-overload branch August 8, 2024 13:48
@Avasam Avasam mentioned this pull request Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaraco jaraco jaraco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Avasam @abravalheri @jaraco