Allow path objects for data-files #4495
Conversation
|
Thanks for the contrib. Unfortunately, |
| elif isinstance(f, Path): | ||
| # it's a simple file, so copy it | ||
| f = convert_path(str(f)) | ||
| if self.warn_dir: | ||
| self.warn( | ||
| "setup script did not provide a directory for " | ||
| f"'{f}' -- installing right in '{self.install_dir}'" | ||
| ) | ||
| (out, _) = self.copy_file(f, self.install_dir) | ||
| self.outfiles.append(out) |
There was a problem hiding this comment.
Looking at this approach, I think I'm going to decline. I want to avoid creating more branches and duplicating more code.
|
Ah my apologies let me know If I can be of any assistance. |
Oh, my mistake. I see now this change is different. The other issue is about Extensions, this is about data files. Still, I'll take the code here and see if I can apply it at distutils. I really appreciate the work! |
Summary of changes
Adds support for
Pathobjects to generate data_files from setup().Closes #4494
Pull Request Checklist
newsfragments/.(See documentation for details)