Replace condition to patch distutils.dist.log
#3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
As `distutils.log.Log` was backfilled for compatibility we no longer can use this as a condition.
abravalheri
force-pushed
the
issue-3707
branch
from
af483dd to
5801753
Compare
|
It seems that the reason why the problem in #3707 was not captured by the existing tests is that the bug requires an unusual arrangement to be triggered:
|
Armin-Gradient
approved these changes
Nov 23, 2022
mttigg
approved these changes
Nov 23, 2022
NikitaSinburt
approved these changes
Nov 23, 2022
moogsG
approved these changes
Nov 23, 2022
|
@jaraco Sorry to bug you, but it looks like @abravalheri is waiting on your review. Just wanted to let you know that |
jaraco
approved these changes
Nov 24, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
distutils.log.Logwas backfilled for compatibility we no longer can use this as a condition.Summary of changes
Closes #3707
Pull Request Checklist
changelog.d/.(See documentation for details)