Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the documentation now points to using environment markers with
install_requires
for declaring platform dependencies, this result in invalid wheels because those are stripped from the final requirements in the embedded metadata.E.g, using something like this:
result in
foo.egg-info/requires.txt
containing:instead of:
which yields:
This PR automatically move requirements in
install_requires
that use environment markers toextras_require
so the egg info is valid and the generated wheels work as expected.Additionally, I added a check to error out if an
extras_require
requirement is itself using an environment marker, as it's not supported.Note: first commit is a fix for the same issue as #1063, so I'll rebase once this is merged.