Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a lower bound pin on setuptools dependency #1088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Nov 24, 2024

mitigates #921

The docs and the checks are still inconsistent (setuptools>=61 & setuptools>=64 are used depending on checks or doc).
This aligns the runtime dependency with the check.

@mayeut
Copy link
Member Author

mayeut commented Nov 24, 2024

re-reading #921, the doc says:

Note: `setuptools-scm>=8` intentionally doesn't depend on setuptools to ease non-setuptools usage.
Please ensure a recent version of setuptools (>=64) is installed.

If the intent of leaving a lower bound blank was for this, then this PR should probably be closed while waiting for one that actually removes the dependency and/or update the check to only run when called from setuptools entrypoints ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants