No need to warn about markdown if it's never used, for #142 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! But this is not necessary. Your issue has been fixed in pypa/twine#421 but hasn't been released yet. |
|
If it matters, I think I agree with @nedbat that even though it's fixed downstream seems unnecessary to warn twice here even if it's fixed downstream too. |
|
I guess in some way it isn't necessary, but only because you know how this file is used in twine. Looked at in isolation, the file still has an annoying behavior: it has the exact same warning twice: once on import, and then again if the renderer is called. That seems unnecessary. |
|
Sounds like you don't want this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out it was super simple.