Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: add git to PATH #930

Merged
merged 7 commits into from
Jun 30, 2023
Merged

Testing: add git to PATH #930

merged 7 commits into from
Jun 30, 2023

Conversation

dukecat0
Copy link
Member

  • I have added an entry to docs/changelog.md

Summary of changes

Add git to PATH during testing, so we can test installing packages with VCS urls.
Closes #303

Test plan

Tested by running

nox -s tests

@dukecat0 dukecat0 marked this pull request as draft January 22, 2023 12:38
@dukecat0 dukecat0 marked this pull request as ready for review January 22, 2023 14:01
@dukecat0 dukecat0 requested a review from uranusjr February 1, 2023 07:06
uranusjr
uranusjr reviewed Jun 28, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@dukecat0 dukecat0 requested a review from uranusjr June 28, 2023 09:45
uranusjr
uranusjr reviewed Jun 28, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
@dukecat0 @uranusjr
Update tests/conftest.py
9041514 
Co-authored-by: Tzu-ping Chung <[email protected]>
@dukecat0 dukecat0 merged commit 6959f93 into pypa:main Jun 30, 2023
@dukecat0 dukecat0 deleted the test-path branch June 30, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing: fixture to temporarily add certain utilities to binary path
2 participants
@dukecat0 @uranusjr