Lint tool version updates #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
This updates the version of black and flake8 to the latest versions in our lint nox session and in
.pre-commit-config.yaml.It takes advantage of the new
--skip-magic-trailing-commaoption in black (added this option to black config inpyproject.toml). I dislike the black "magic trailing comma" behavior because it treats all trailing commas as a user directive to never collapse a multi-line list, even in those cases that black and not the user added the trailing comma in the first place. See psf/black#1742 . Before I had kept the version of black at 19.10b0 to avoid this new magic comma behavior, but with the new switch we can advance black to the latest version.In addition, with the new switch, there were some unnecessary trailing commas in a few source files that got cleaned up.
Test plan
Tested by running