Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arch installation and fix flags order #1396

Merged
merged 3 commits into from
May 15, 2024

Conversation

Paiusco
Copy link
Contributor

@Paiusco Paiusco commented May 11, 2024

  • I have added a news fragment under changelog.d/ (if the patch affects the end users)

Summary of changes

  • Add Arch as Linux option on installation steps

@chrysle
Copy link
Contributor

chrysle commented May 11, 2024

Thanks! The order has already been corrected in #1338, which will be merged soon.

@Paiusco
Copy link
Contributor Author

Paiusco commented May 11, 2024

@chrysle my bad, I'll remove the parameter fix, but will leave only the Arch addition then.

README.md Outdated Show resolved Hide resolved
@dukecat0
Copy link
Member

Please add a changelog entry as well.

@Paiusco
Copy link
Contributor Author

Paiusco commented May 11, 2024

Should it be added to the changelog even tho it doesn't affect the end users? I don't see a reason to flood the changelog just for adding a new instruction for a distro

Co-authored-by: Jason Lam <[email protected]>
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat enabled auto-merge (squash) May 13, 2024 17:15
@huxuan
Copy link
Member

huxuan commented May 15, 2024

Hi @Paiusco, the pull request need to be updated for merge.

@gaborbernat gaborbernat merged commit ffba90c into pypa:main May 15, 2024
13 checks passed
@Paiusco Paiusco deleted the update-README-arch branch May 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants