-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default logging level to WARNING #1178
Conversation
Probably we need to update this line to Line 720 in 81c2fa5
|
Yes, looks like it. |
We can change its behavior instead of removing it. I remember the original usage of this flag was hiding all console outputs, not just the debug log messages. |
It might be so but: If there are more changes to be made as you suggest, then it would be for another PR but for now, I think changing back this test is the best option. |
I've opened #1181 to revert it now. |
docs/changelog.md
Summary of changes
Set the default logging level to WARNING, so debug log messages won't be shown without passing additional flags such as
--verbose
.Closes #1175
Closes #1177
Test plan
Tested by running