inject should print summary after successful injection #223
Labels
enhancement
New feature or request
Comments
itsayellow
added a commit
to itsayellow/pipx
that referenced
this issue
Sep 25, 2019
cs01
pushed a commit
that referenced
this issue
Oct 9, 2019
* Add printed summary after successful injection. Fixes Issue #223. * Modify test assertions for new inject summary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
How would this feature be useful?
Currently when inject is done, it just says "done!", which is inconsistent with install, for example, which says something like "installed package
<package><version>, Python<py_version>" before saying "done!".Describe the solution you'd like
inject should say something that is consistent with install, such as "injected dependency
<injected_package>into the virtual environment of<package>"Describe alternatives you've considered
None. This should be simple.
I noticed this when implementing pipxrc (#222) and reinstalling all packages AND their injected packages. A series of reinstalled packages makes sense, with a line saying what package has just been installed, but for each injected package that is re-injected, there are just extra lines of "done!" multiple times, which is not particularly informative or sensible.
The text was updated successfully, but these errors were encountered: