Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject --include-binaries on a package without binaries will remove already-existing binaries #137

Closed
ghost opened this issue Apr 9, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented Apr 9, 2019

Using inject --include-binaries original new on a new package that doesn't have binaries will remove the existing binaries from PATH.

# Create a virtualenv with ipython binary
pipx install ipython
# Add black binary to the virtualenv
pipx inject --include-binaries ipython black
which black
# Add toolz to the virtualenv, even though it doesn't have a binary
pipx inject --include-binaries ipython toolz 
# Black is now missing
which black

I do this --inject-binaries even for packages that don't have binaries because I like to have a main virtualenv with most of my things in it. I want to run a single command to get everything I need. Since pipx doesn't yet support a single command to get multiple things, I'm splitting it into two.

pipx install ipython
pipx inject  --include-binaries ipython toolz pytest attrs
@cs01
Copy link
Member

cs01 commented Apr 24, 2019

Thank you for reporting and following up. The reproduction was straightforward thanks to your code block. This has been fixed in 0.13.1.0.

@cs01 cs01 closed this as completed Apr 24, 2019
gh271 pushed a commit to gh271/pipx that referenced this issue Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant