Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 5456 #5464

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Issue 5456 #5464

merged 4 commits into from
Nov 10, 2022

Conversation

matteius
Copy link
Member

Thank you for contributing to Pipenv!

The issue

Fixes #5456

After named package categories was released, the lock file generation had the default behavior of --keep-outdated being passed true.

@matteius matteius requested a review from oz123 November 10, 2022 06:52
@oz123
Copy link
Contributor

oz123 commented Nov 10, 2022

Code linting is broken, but other than that it looks fine .

@oz123 oz123 merged commit a4d0425 into main Nov 10, 2022
@oz123 oz123 deleted the issue-5456 branch November 10, 2022 08:27
@JGSweets
Copy link

FYI, I believe this PR has introduced a bug for local packages.
The lines:

if not keep_outdated:
    try:
        del lockfile[category]
    except KeyError:
        pass

forces the category to be resolved latter. This strips the path key for local packages which does not get reintroduced into the lockfile later. This causes a cannot resolve package error during installation despite Pipfile.lock being created.

i.e. the Pipfile.lock for the <LOCAL_PACKAGE> loses the path.

"<LOCAL_PACKAGE>": {
    "hashes": [
        "sha256:<VALUE>"
    ],
    "path": "<PATH>"
}

becomes

"<LOCAL_PACKAGE>": {
    "hashes": [
        "sha256:<VALUE>"
    ]
}

@oz123
Copy link
Contributor

oz123 commented Dec 16, 2022

Can you please open a separate issue, so it's easier to track?

@JGSweets
Copy link

Can you please open a separate issue, so it's easier to track?

#5542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipenv 2022.10.25 does not appear to correctly prune obsolete dependencies
3 participants