Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a context manager to handle the temporary constraints file #5316

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

swaldhoer
Copy link
Contributor

Change #5313 to use a context manager as best practices suggest.

@matteius
Copy link
Member

matteius commented Sep 1, 2022

@swaldhoer please add a news fragment like 5316.trivial.rst for this change.

@swaldhoer
Copy link
Contributor Author

@swaldhoer please add a news fragment like 5316.trivial.rst for this change.

Done.

@matteius matteius requested a review from oz123 September 1, 2022 23:04
@matteius matteius merged commit c7499e8 into pypa:main Sep 2, 2022
@swaldhoer swaldhoer deleted the use-context-manager branch September 2, 2022 08:39
yeisonvargasf pushed a commit to yeisonvargasf/pipenv that referenced this pull request Nov 19, 2022
…5316)

* Use a context manager to handle the temporary constraints file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants