Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This could improve the case of upstream dependencies that mess up the… #4982

Closed
wants to merge 2 commits into from
Closed

This could improve the case of upstream dependencies that mess up the… #4982

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
218c559
This could improve the case of upstream dependencies that mess up the…
matteius Mar 12, 2022
9b947ae
make log error more clear.
matteius Mar 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions pipenv/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,11 +897,18 @@ def resolve_constraints(self):
if candidate:
requires_python = candidate.link.requires_python
if requires_python:
marker = marker_from_specifier(requires_python)
self.markers[result.name] = marker
result.markers = marker
if result.req:
result.req.marker = marker
try:
marker = marker_from_specifier(requires_python)
self.markers[result.name] = marker
result.markers = marker
if result.req:
result.req.marker = marker
except TypeError as e:
click_echo(
f"Error generating python marker for {candidate}. "
f"Is the specifier {requires_python} incorrectly quoted or otherwise wrong?"
f"Full error: {e}", err=True
)
new_tree.add(result)
self.resolved_tree = new_tree

Expand Down