Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect environment when inside venv #4284

Merged
merged 2 commits into from
May 29, 2020
Merged

Fix incorrect environment when inside venv #4284

merged 2 commits into from
May 29, 2020

Conversation

frostming
Copy link
Contributor

@frostming frostming commented May 29, 2020 •
edited
Loading

Thank you for contributing to Pipenv!

The issue

When using an outer Pipenv inside an activated venv, system-wide python will be used.

Fix #4276
Fix #4220

@frostming frostming added Priority: High This item is high priority and should be resolved quickly. Type: Bugfix This issue provides a fix for a known bug. Type: Regression This issue is a regression of a previous behavior. labels May 29, 2020
techalchemy
techalchemy approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@techalchemy techalchemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an identical fix locally, this is absolutely the exact problem

@techalchemy
Copy link
Member

does azure ever succeed :|

@frostming frostming merged commit a8bf65a into master May 29, 2020
@frostming frostming deleted the bugfix/4276 branch May 29, 2020 07:10
@frenzymadness frenzymadness mentioned this pull request Jun 1, 2020
Closed
@techalchemy techalchemy added this to the 2020.6.x bugfix release milestone Jun 2, 2020
@techalchemy techalchemy mentioned this pull request Jun 2, 2020
Closed
@nstapelbroek nstapelbroek mentioned this pull request Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techalchemy techalchemy techalchemy approved these changes

Assignees
No one assigned
Labels
Priority: High This item is high priority and should be resolved quickly. Type: Bugfix This issue provides a fix for a known bug. Type: Regression This issue is a regression of a previous behavior.
Projects
None yet
Milestone
2020.6.x bugfix release
2 participants
@frostming @techalchemy