Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python path discovery if not called python #3330

Merged
merged 17 commits into from
Mar 18, 2019
Merged

Conversation

techalchemy
Copy link
Member

@techalchemy techalchemy commented Nov 30, 2018

Fix python path discovery if not called python

- Begin a refactor of `delegator.run` invocation to ensure we capture
  and handle failures with our own exception wrappers
- Additoinally capture output and error logging and command information
  when running in verbose mode (should avoid significant repitition in
  the codebase)
- Refactor `which` and `system_which` to fallback to pythonfinder's
implementation
- Abstract `is_python_command` to identify whether we are looking for
  python, this enables us to rely on `pythonfinder.Finder.find_all_python_versions()`
  to ensure we aren't skipping python versions
- Fixes #2783

Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>

Update azure builds

Signed-off-by: Dan Ryan <[email protected]>

Update azure pipeline windows code

Signed-off-by: Dan Ryan <[email protected]>

Update python executable search for windows

Signed-off-by: Dan Ryan <[email protected]>

Fix variable reference

Signed-off-by: Dan Ryan <[email protected]>

Set virtual env variable on windows

Signed-off-by: Dan Ryan <[email protected]>

globally install pipenv on windows

Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>

Fix variable references

Signed-off-by: Dan Ryan <[email protected]>

Fix variable references

Signed-off-by: Dan Ryan <[email protected]>

Switch to powershell for windows virtualenv creation

Signed-off-by: Dan Ryan <[email protected]>

use python version as path

Signed-off-by: Dan Ryan <[email protected]>

use python version as path

Signed-off-by: Dan Ryan <[email protected]>

swap variable name for python exe

Signed-off-by: Dan Ryan <[email protected]>

add fallback for python exe

Signed-off-by: Dan Ryan <[email protected]>

fix python variable setting

Signed-off-by: Dan Ryan <[email protected]>

fix python variable setting

Signed-off-by: Dan Ryan <[email protected]>

Use variable susbstitution for python executable location

Signed-off-by: Dan Ryan <[email protected]>

Use activate script properly

Signed-off-by: Dan Ryan <[email protected]>

Fix floating quote in python version

Signed-off-by: Dan Ryan <[email protected]>

Don't block on safety call in python 2 as it overwrites output for some reason

Signed-off-by: Dan Ryan <[email protected]>

Don't block on pipenv graph either

Signed-off-by: Dan Ryan <[email protected]>

Check command return code instead of calling `block`

Signed-off-by: Dan Ryan <[email protected]>

Don't load json after its already loaded

Signed-off-by: Dan Ryan <[email protected]>

Wait on return code before checking contents

Signed-off-by: Dan Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants