Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leading dashes in venv names #2399

Closed
wants to merge 2 commits into from
Closed

Remove leading dashes in venv names #2399

wants to merge 2 commits into from

Commits on Jun 21, 2018

  1. Add failing test

    @dnoetzel
    dnoetzel committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    e5ac053 View commit details
    Browse the repository at this point in the history

  2. Allow virtual env creation in dir with leading dash 

    If the name given to a virtualenv starts with a dash, it can be
misinterpreted as an argument when passed to external commands,
such as when pew is used create a new virtual environment.

Since pipenv has not been able to create a virtual environment in
a directory whose name begins with a dash, there are no deployments
to break with this change.

Fixes pypa#439
    @dnoetzel
    dnoetzel committed Jun 21, 2018
    Configuration menu
    Copy the full SHA
    6b8e150 View commit details
    Browse the repository at this point in the history