Refactor and cleanup some locking code #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Jun 7, 2018
| 'log_string': 'packages', | ||
| 'dev': False | ||
| } | ||
| } |
There was a problem hiding this comment.
This will make the section ordering non-deterministic in older Python versions. Probably better to use a list instead. (Or the user could be confused.)
uranusjr
reviewed
Jun 7, 2018
pipenv/core.py
Outdated
| continue | ||
| lockfile['default'].update( | ||
| {dep['name']: {'version': '=={0}'.format(dep['version'])}} | ||
| # Add develop dependencies to lockfile. |
|
That resolver failure is so consistent on appveyor now, I wonder what the real cause of it is... |
- This has been driving me mad. Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]>
- Cleanup stale comments - Deterministic ordering for locking Signed-off-by: Dan Ryan <[email protected]>
techalchemy
force-pushed
the
resolver-refactor
branch
from
6d9ec90
to
be75afb
Compare
uranusjr
added
the
PR: awaiting-merge
uranusjr
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Ryan [email protected]