-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer colorized on Windows #3020
Comments
We disabled colouring on native Powershell due to complaints about the scheme not being compatible with the default blue background. We recommend using a terminal emulator, such as Cmder. @erinxocon Would it be possible to add an environment variable to enable colouring in native Powershell? |
didnt we reenable already? |
i'll hopefully cut a release tomorrow, besides this and anything else you flag i'm good with the current code @uranusjr |
@techalchemy I believe it is enabled only if Powershell is run “non-natively” (e.g. inside Cmder). I’m good with a new release though. |
@uranusjr @techalchemy For the record, I have the same "problem" when running from within VS Code. I don't know if that's running "natively" or not, but it uses the color scheme of VS Code, not the default powershell blue that people were complaining about. |
- Swap native blue for magenta - Fixes #3020 Signed-off-by: Dan Ryan <[email protected]>
- Fix #3020 - Fix #3088 - Patch delegator - Add weakref finalizer for tempfiles Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]> Update vendored dependencies Signed-off-by: Dan Ryan <[email protected]> Fix file handle leaks - Fix #3020 - Fix #3088 - Patch delegator - Add weakref finalizer for tempfiles Signed-off-by: Dan Ryan <[email protected]> Fix spinner handlers on windows Signed-off-by: Dan Ryan <[email protected]> Fix spinner output and encoding issue Signed-off-by: Dan Ryan <[email protected]> fix encoding Signed-off-by: Dan Ryan <[email protected]> Fix unicode output on windows, fix tomlkit imports Signed-off-by: Dan Ryan <[email protected]> Unvendor boltons, fix compatibility, update merge functionalities Signed-off-by: Dan Ryan <[email protected]> Update pythonfinder, vistir version, requirementslib version Signed-off-by: Dan Ryan <[email protected]> Fix vendoring script Signed-off-by: Dan Ryan <[email protected]> Silence pip version checks Signed-off-by: Dan Ryan <[email protected]> Add debugging to locking Signed-off-by: Dan Ryan <[email protected]>
Issue description
Latest version (
2018.10.9
) of pipenv breaks colorized console output on Windows Powershell (and VS Code)Expected result
Colorized output should continue working as in previous version of pipenv
Actual result
Pipenv colorized output stops immediately upon upgrading to latest pipenv
Steps to replicate
(Compare to old pipenv version)
$ pipenv --support
Pipenv version:
'2018.10.9'
Pipenv location:
'c:\\users\\moonb\\miniconda3\\lib\\site-packages\\pipenv'
Python location:
'c:\\users\\moonb\\miniconda3\\python.exe'
Python installations found:
4.5.11
:C:\Users\moonb\Miniconda3\python.exe
PEP 508 Information:
System environment variables:
ALLUSERSPROFILE
APPDATA
COMMONPROGRAMFILES
COMMONPROGRAMFILES(X86)
COMMONPROGRAMW6432
COMPUTERNAME
COMSPEC
DRIVERDATA
FPS_BROWSER_APP_PROFILE_STRING
FPS_BROWSER_USER_PROFILE_STRING
GOROOT
HOMEDRIVE
HOMEPATH
LOCALAPPDATA
LOGONSERVER
NUMBER_OF_PROCESSORS
OCULUSBASE
ONEDRIVE
OS
PATH
PATHEXT
PROCESSOR_ARCHITECTURE
PROCESSOR_IDENTIFIER
PROCESSOR_LEVEL
PROCESSOR_REVISION
PROGRAMDATA
PROGRAMFILES
PROGRAMFILES(X86)
PROGRAMW6432
PSMODULEPATH
PUBLIC
SESSIONNAME
SYSTEMDRIVE
SYSTEMROOT
TEMP
TMP
USERDOMAIN
USERDOMAIN_ROAMINGPROFILE
USERNAME
USERPROFILE
WINDIR
PYTHONDONTWRITEBYTECODE
PIP_SHIMS_BASE_MODULE
PIP_PYTHON_PATH
Pipenv?specific environment variables:
Debug?specific environment variables:
PATH
:C:\Program Files\Oculus\Support\oculus-runtime;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Go\bin;C:\Program Files (x86)\NVIDIA Corporation\PhysX\Common;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\130\Tools\Binn\;C:\Program Files (x86)\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\Microsoft SQL Server\130\Tools\Binn\;C:\Program Files\Microsoft SQL Server\130\DTS\Binn\;C:\Program Files\PuTTY\;C:\Users\moonb\AppData\Local\Programs\MiKTeX 2.9\miktex\bin\x64;C:\WINDOWS\System32\OpenSSH\;C:\Program Files\Git\cmd;C:\Program Files\nodejs\;C:\Program Files\Microsoft VS Code\bin;C:\Users\moonb\Miniconda3;C:\Users\moonb\Miniconda3\Scripts;C:\Users\moonb\AppData\Local\Microsoft\WindowsApps;C:\Users\moonb\AppData\Local\atom\bin;C:\Users\moonb\AppData\Local\Microsoft\WindowsApps;C:\Users\moonb\AppData\Local\GitHub\PortableGit_f02737a78695063deace08e96d5042710d3e32db\cmd;C:\Program Files\Microsoft VS Code\bin;C:\Users\moonb\AppData\Local\Pandoc\;C:\Users\moonb\AppData\Local\Programs\MiKTeX 2.9\miktex\bin\x64\;C:\Users\moonb\AppData\Roaming\npm;
Contents of
Pipfile
('C:\Users\moonb\Documents\dev_local\pipfile-sync\Pipfile'):Contents of
Pipfile.lock
('C:\Users\moonb\Documents\dev_local\pipfile-sync\Pipfile.lock'):The text was updated successfully, but these errors were encountered: