-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipenv update does not update library when GitHub ref in Pipfile is updated #1690
Comments
Thanks for the report! |
I think ref is intended to only work in the lockfile, not in the pipfile. |
My goal is to pin my installed libraries to specific git commit hashes. With pip, I would update What's the suggested workflow for Pipenv? Or is this not a supported scenario? |
Yeah this is quite irritating - the best workaround I've found is to have the person updating the ref to manually install the new version via |
Yeah I find it irritating myself. I know how to handle it even, just haven’t had a chance. Had this issue sitting open in a tab in my browser for weeks. |
@kennethreitz what's the correct way to force the update of source revision? Sounds like manually editing the lock file? We have 2 source references in our codebase and whenever they're updated it causes pain in environments that already have a copy of a given source dep as they aren't updated. The workflow we've used to date has been as below. Is there something we should be doing to ensure environments are updated correctly when New Dependency
Existing Dependency
|
Running |
@techalchemy sorry forgot Expected/Actual results. It appears for the person that runs My expectation would be that sync would update the source for other environments but it doesn't appear to do that or we're doing something wrong. |
Sync means “synchronise the current environment based on the locked versions”. It does not affect anything except the currently using virtual environment. |
- Manually obtain and update VCS repository with exact commit - Always store exact commit in the lockfile - Fixes #2180, #1690, #1611, #2096 Signed-off-by: Dan Ryan <[email protected]>
- Manually obtain and update VCS repository with exact commit - Always store exact commit in the lockfile - Fixes #2180, #1690, #1611, #2096 Signed-off-by: Dan Ryan <[email protected]>
- Manually obtain and update VCS repository with exact commit - Always store exact commit in the lockfile - Fixes pypa#2180, pypa#1690, pypa#1611, pypa#2096 Signed-off-by: Dan Ryan <[email protected]>
First of all, thanks for improving Python packaging. I'm experimenting with Pipenv on some side projects before bringing it into my team's mainline dev workflow.
Brief description
$ pipenv update
does not update library when a ref is changed in the PipfilePipfile Snippet 1:
Pipfile Snippet 2:
Expected result
I assumed that by changing the ref in
Pipfile
to a different commit hash and running$ pipenv update
that the old verison of the library would have been removed and the new version would have been installed.Actual result
The old version stayed in place.
Steps to replicate
Environment:
Pipenv location:
'/Users/paul/.pyenv/versions/venv_crypto_tracker/lib/python3.6/site-packages/pipenv'
Python location:
'/Users/paul/.pyenv/versions/venv_crypto_tracker/bin/python'
Other Python installations in
PATH
:2.7
:/usr/bin/python2.7
2.7
:/Users/paul/.pyenv/shims/python2.7
2.7
:/usr/bin/python2.7
3.4
:/Users/paul/.pyenv/shims/python3.4
3.5
:/Users/paul/.pyenv/shims/python3.5
3.6
:/usr/local/bin/python3.6m
3.6
:/Users/paul/.pyenv/shims/python3.6
3.6
:/usr/local/bin/python3.6
3.6
:/usr/local/bin/python3.6
3.6.2
:/Users/paul/.pyenv/versions/venv_crypto_tracker/bin/python
3.6.2
:/Users/paul/.pyenv/shims/python
2.7.10
:/usr/bin/python
None
:/Users/paul/.pyenv/shims/python2
3.6.2
:/Users/paul/.pyenv/versions/venv_crypto_tracker/bin/python3
3.6.2
:/Users/paul/.pyenv/shims/python3
3.6.4
:/usr/local/bin/python3
3.6.4
:/usr/local/bin/python3
PEP 508 Information:
System environment variables:
PIP_DOWNLOAD_CACHE
LDFLAGS
TERM_PROGRAM
PIP_REQUIRE_VIRTUALENV
PYENV_ROOT
SHELL
TERM
HISTSIZE
TMPDIR
CPPFLAGS
Apple_PubSub_Socket_Render
TERM_PROGRAM_VERSION
TERM_SESSION_ID
PYENV_VERSION
USER
HISTFILESIZE
REACT_EDITOR
SSH_AUTH_SOCK
PYENV_DIR
__CF_USER_TEXT_ENCODING
PYENV_VIRTUALENV_INIT
VIRTUAL_ENV
PYENV_VIRTUAL_ENV
PATH
PWD
EDITOR
LANG
ITERM_PROFILE
PYENV_HOOK_PATH
XPC_FLAGS
_OLD_VIRTUAL_PS1
ITERM_ORIG_PS1
RBENV_SHELL
XPC_SERVICE_NAME
HISTCONTROL
COLORFGBG
HOME
SHLVL
PYENV_SHELL
ITERM_PREV_PS1
ITERM_SESSION_ID
LOGNAME
PKG_CONFIG_PATH
ARCHFLAGS
DISPLAY
COLORTERM
PIP_PYTHON_PATH
PYTHONUNBUFFERED
Pipenv–specific environment variables:
Debug–specific environment variables:
PATH
:/Users/paul/.pyenv/versions/venv_crypto_tracker/bin:/usr/local/Cellar/pyenv/1.2.2/libexec:/Users/paul/.npm-global/bin:/usr/local/Cellar/pyenv-virtualenv/1.1.1/shims:/Users/paul/.pyenv/shims:/Users/paul/google-cloud-sdk/bin:/usr/local/heroku/bin:/Users/paul/.rbenv/shims:/usr/local/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin:/usr/local/sbin
SHELL
:/bin/bash
EDITOR
:idea
LANG
:en_US.UTF-8
PWD
:/Users/paul/code/CleverPoint/crypto_tracker/django_project
VIRTUAL_ENV
:/Users/paul/.pyenv/versions/3.6.2/envs/venv_crypto_tracker
Contents of
Pipfile
('/Users/paul/code/CleverPoint/crypto_tracker/django_project/Pipfile'):Contents of
Pipfile.lock
('/Users/paul/code/CleverPoint/crypto_tracker/django_project/Pipfile.lock'):The text was updated successfully, but these errors were encountered: