-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traceback on Windows 10 involving _psutil_windows #1587
Comments
I also got pipenv trying to use miniconda instead of the Python interpreter I used to launch pipenv when running |
Same on 11.1.3 |
this wasn't happening before? |
I reverted to 11.1.0 to resolve my issue temporarily. |
I have no idea if the issue was occurring previously because I was blocked on #1474 until now. |
will get a fix out shortly |
once i can reproduce |
I've been running into this issue today as well. I reverted to pipenv 9.1.0 (since that version is working on another machine) and all is well. On my systems, psutil gets installed directly in site-packages and has the |
@kennethreitz @brettcannon I've run into this before, internally we've discussed why we are even vendoring this, it breaks windows on occasion and I don't think anyone knows why it's vendored now. We might be ok just unvendoring this -- /cc @nateprewitt FWIW in the past I've resolved this by reinstalling my environment and/or reinstalling pipenv/psutil, no idea why though... |
/cc @uranusjr for windows knowledge also |
Pew also depends on psutil on Windows. It was using the site-packages version before, but not it detects the one vendored by Pipenv. My guess is this has something to do with the I’m +1 for unvendoring psutil because this is a bit complicated to solve otherwise. |
Wondering if this is one of those “subtly different” things. https://twitter.com/dontusethiscode/status/968637241374466053 |
- Use native ctypes for parent process traversal - Addresses issues raised in pypa/pipenv#1587 and microsoft/vscode-python#978 - Improves speed on windows - Allows pipenv to remove vendored psutil which sometimes fails to find linked python dlls
Assuming the PR I just submitted doesn't hit any stumbling blocks building against pypy or nix, I just introduced some changes to just remove psutil from the picture entirely |
- Use native ctypes for parent process traversal - Addresses issues raised in pypa/pipenv#1587 and microsoft/vscode-python#978 - Improves speed on windows - Allows pipenv to remove vendored psutil which sometimes fails to find linked python dlls
And there you are submitting the “complicated otherwise” solution like it’s nothing… 🤯 |
I got this as well on pipenv 11.1.3. It seems like the vendor version of psutil doesnt have the file _psutil_windows.cp36-win_amd64.pyd which is present when I install psutil normally. |
As @randycoulman I reverto to pipenv 10.1.0 and now all is working fine. These are the packages version installed on my environment. (Windows 10 64bit with Python 3.6 32bit)
|
fixed in master |
released! |
@brettcannon @uranusjr @siddhi @joshcurago we are now vendoring a patched version of pew with a native ctypes implementation of the things they were using |
done! |
I can confirm that 11.1.5 now works for me. Thanks for the quick turnaround! |
- Use native ctypes for parent process traversal - Addresses issues raised in pypa/pipenv#1587 and microsoft/vscode-python#978 - Improves speed on windows - Allows pipenv to remove vendored psutil which sometimes fails to find linked python dlls
- Use native ctypes for parent process traversal - Addresses issues raised in pypa/pipenv#1587 and microsoft/vscode-python#978 - Improves speed on windows - Allows pipenv to remove vendored psutil which sometimes fails to find linked python dlls
Be sure to check the existing issues, both open and closed.
Describe the issue briefly here.
Describe your environment
$ python -V
: 3.6.4$ pipenv --version
: 11.1.2Expected result
No traceback
Actual result
Steps to replicate
Command in output above.
The text was updated successfully, but these errors were encountered: