Remove obsolete "# type: ignore" comments #9340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The lint failures will be resolved after #9335 lands. I'll rebase after that happens. |
uranusjr
added
the
skip news
|
It looks like macOS is failing intermittently due to some kind of timeout. First it was failing on 3.6, which is now passing, but now it is failing on 3.7, which previously passed. |
Obsolete since dropping Python 2 support. Add the mypy setting "warn_unused_ignores = True" to catch these earlier.
|
Yea, Github is doing something with their CI setup. |
uranusjr
reviewed
Dec 24, 2020
uranusjr
approved these changes
Dec 24, 2020
|
Thanks! ^.^ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obsolete since dropping Python 2 support.
Add the mypy setting "warn_unused_ignores = True" to catch these
earlier.