Change assertion in topological sorting #9055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
kind: workaround
|
I don't think this needs a NEWS entry, since it's merely updating an assertion. Holler if you disagree. :) |
pfmoore
approved these changes
Oct 26, 2020
|
And this is why we have CI and linters, because OF COURSE I forgot to update the type annotation. :) |
|
... and it's why whenever I approve something there's an implied "as long as the tests all pass" 🙂 |
|
Oh look, past-me wrote easy to reason about tests. I see this as a win. |
|
Awesome. We're golden here. |
uranusjr
approved these changes
Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9031