Replace custom URL parsing with url_to_path() #8830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
skip news
uranusjr
force-pushed
the
env-var-req-file
branch
from
b097953
to
87d129a
Compare
pradyunsg
approved these changes
Sep 1, 2020
xavfernandez
approved these changes
Sep 4, 2020
|
Let's see if the travis failure was a transient. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered this while looking into #8765 and #8828. The requirements file parser contains this buggy hand-rolled logic to convert a
file://to a local filesystem path.pip._internal.utils.urls.url_to_path()(andurllib.request.url2pathname()it calls underneath) can do everything it does better, and can handle more edge cases on Windows.For additional information, the current hand-rolled implementation did not change since the initial commit in this repository.