-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendoring Updates: July 2020 #8611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
the
type: maintenance
Related to Development and Maintenance Processes
label
Jul 22, 2020
pradyunsg
force-pushed
the
vendoring/july-2020
branch
from
July 22, 2020 02:08
75677c2
to
db669e7
Compare
Note: I'm not touching the tox CI pin for vendoring==0.2.2, since it's easier to audit/review when less things are changing. |
pradyunsg
force-pushed
the
vendoring/july-2020
branch
from
July 22, 2020 02:15
db669e7
to
0142131
Compare
Also, drop the no-longer-necessary patch.
This should make debugging issues in this test easier.
This is a fix for the sole failing test in the CI for these changes (in tests/functional/test_debug.py::test_debug__library_versions). The failure took me a fair bit of time to diagnose, but it looks like the issue is that we're strictly comparing versions as strings. This is a bad idea when they're not normalized.
pradyunsg
force-pushed
the
vendoring/july-2020
branch
from
July 23, 2020 16:51
0142131
to
dcfea6e
Compare
Merging since CI approves, and I don't think the patches are controversial. Holler in the (currently pinned) 20.2 release issue if they are! |
Yay for packaging 20.4 which has PEP 600 parsing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8446
Closes #8591
Closes #8478
Created using #8610, but rebased to remove the automation-logic commit.
Notable details:
setuptools
orpkg_resources
.html5lib
patch is no longer needed, since they made the new release containing those changes! 🎉certifi
gets a new.patch
file, to usepip._vendor.certifi
as the namespace, when loadingcacert.pem
.requests
has an update to its' patch, since the underlying logic changed a bit.