-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve install conflict warning #8594
Improve install conflict warning #8594
Conversation
I think this doesn't need dedicated tests, since (1) I'm lazy (2) see 1 and (3) this is an error messaging change and I'm genuinely not sure if we need additional tests for this. Oh, and because I'm bored, here's before/after screenshots, from a 80-char wide terminal: Before: After: Honestly, I don't like how either output looks but that's maybe more #4649 thing. :) |
I've posted recommendation on in #8546 what the output message should be, how it should be formatted and how a portion should be hidden after 48 hours. |
e3defa0
to
08cc238
Compare
08cc238
to
8db3542
Compare
Okay, looks like past me wrote a lot more tests than I'd thought. :) I'll let the CI run and come back after lunch. |
This also updates invocations that can't be translated as-is into a different equivalent check.
bcb80d7
to
3962f9d
Compare
OH COME ON. |
Retriggered the CI -- hopefully it'll not fail again because PyPI wasn't responding to XMLRPC for a minute. |
Thanks for the review @pfmoore! |
Closes #8546
Resolves #8513
Changes
To