Make wheel header installation test more explicit #8534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have one test that headers in a wheel are handled correctly. Previously, this test was just checking that the
.dist-info
folder was getting created. Now we check that the header file is actually installed. I also took the opportunity to replace a custom-created wheel with ourmake_wheel
helper.For reference, the contents of the removed
tests/data/packages/headers.dist-0.1-py2.py3-none-any.whl
:headersdist.py
andmetadata.json
did not seem relevant to the current test, so they have been omitted in the wheel we now construct at runtime.Progresses #6030.