Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add methods for path lookups in test_download.py and test_new_resolver.py #8370

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Add methods for path lookups in test_download.py and test_new_resolver.py #8370

merged 2 commits into from
Jun 9, 2020

Conversation

ssurbhi560
Copy link
Contributor

Towards #6050

McSinyx
McSinyx reviewed May 31, 2020
View reviewed changes
Copy link
Contributor

@McSinyx McSinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I think many of the calls to result.did_create may fit on one single line.

pradyunsg
pradyunsg approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to avoid breaking up these calls unnecessarily (when they fit in a line), but that's not a blocker IMO. :)

@sbidoul sbidoul merged commit ca43901 into pypa:master Jun 9, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@McSinyx McSinyx McSinyx left review comments

@pradyunsg pradyunsg pradyunsg approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ssurbhi560 @uranusjr @pradyunsg @McSinyx @sbidoul